Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#TRUNK-4159] Add OrderFrequency to the data model #475

Closed
wants to merge 2 commits into from

Conversation

k-joseph
Copy link
Member

https://tickets.openmrs.org/browse/TRUNK-4159 added order_frequency to the data model

public void setConcept(Concept concept) {
this.concept = concept;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to override to string as below:
public String toString(){
(getConcept() == null) ? null : getConcept().getName();
}

</column>
<column name="retired_by" type="int" />
<column name="date_retired" type="datetime"/>
<column name="retire_reason" type="varchar(255)" defaultValue="null"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to specify a default value of null, i fixed it as i merged the code

@wluyima
Copy link
Member

wluyima commented Dec 18, 2013

Merged at c40f3d9

@wluyima wluyima closed this Dec 18, 2013
@wluyima wluyima reopened this Dec 19, 2013
</createTable>
</changeSet>

<changeSet id="201312181512-TRUNK-4159" author="k-joseph">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to split up this and add each changeset individually, also you need to include a precondition for each to check that the foreign key doesn't exist

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better you can move them to the changeset that creates the tables, this is okay if you in include the in the same changeset that creates the table

@k-joseph k-joseph closed this Dec 19, 2013
@k-joseph k-joseph deleted the TRUNK-4159 branch December 19, 2013 10:48
RandilaP pushed a commit to RandilaP/openmrs-core that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants