New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#TRUNK-4159] Add OrderFrequency to the data model #475
Conversation
public void setConcept(Concept concept) { | ||
this.concept = concept; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to override to string as below:
public String toString(){
(getConcept() == null) ? null : getConcept().getName();
}
</column> | ||
<column name="retired_by" type="int" /> | ||
<column name="date_retired" type="datetime"/> | ||
<column name="retire_reason" type="varchar(255)" defaultValue="null"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to specify a default value of null, i fixed it as i merged the code
Merged at c40f3d9 |
</createTable> | ||
</changeSet> | ||
|
||
<changeSet id="201312181512-TRUNK-4159" author="k-joseph"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to split up this and add each changeset individually, also you need to include a precondition for each to check that the foreign key doesn't exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even better you can move them to the changeset that creates the tables, this is okay if you in include the in the same changeset that creates the table
https://tickets.openmrs.org/browse/TRUNK-4159 added order_frequency to the data model