TRUNK-3407: ConceptDescription equals method fails with 2 different instances of ConceptDescription in 1.8 and earlier #282
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstances of ConceptDescription in 1.8 and earliergit
|
Fixed unit test |
|
Haha, I call it java black magic (http://stackoverflow.com/questions/3637936/java-integer-equals-vs#answer-3637974) 1989 makes a difference, because it is bigger than 127 Or did you mean something different? |
|
Does your current unit test fail without your changes in the equals method? |
|
It does fail without changes, it doesn't fail with. |
|
Please, have a look - https://www.dropbox.com/sh/zujomeum91g0qce/hcDmolHEmI#/ |
|
I think you could just do twice "new Integer(1)" to get 2 different objects to test the fix easier. Anyway, it's all good. I'm merging and closing. Thanks Fillip! |
rkorytkowski
added a commit
that referenced
this pull request
Jun 18, 2013
TRUNK-3407: ConceptDescription equals method fails with 2 different instances of ConceptDescription in 1.8 and earlier
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change == to equals() for comparing Integers
https://tickets.openmrs.org/browse/TRUNK-3407