unix: revert 98b9f58 and 431195c for now, corrupts memory

joyent · Sep 9, 2011 · ca5346f · ca5346f
1 parent e95a29e
commit ca5346f
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 164 deletions.
diff --git a/src/unix/core.c b/src/unix/core.c
@@ -235,8 +235,6 @@ void uv__finish_close(uv_handle_t* handle) {
     case UV_TCP:
       assert(!ev_is_active(&((uv_stream_t*)handle)->read_watcher));
       assert(!ev_is_active(&((uv_stream_t*)handle)->write_watcher));
-      assert(((uv_stream_t*)handle)->fd == -1);
-      uv__stream_destroy((uv_stream_t*)handle);
       break;
 
     case UV_UDP:

diff --git a/src/unix/internal.h b/src/unix/internal.h
@@ -81,7 +81,6 @@ void uv_fatal_error(const int errorno, const char* syscall);
 
 /* stream */
 int uv__stream_open(uv_stream_t*, int fd, int flags);
-void uv__stream_destroy(uv_stream_t* stream);
 void uv__stream_io(EV_P_ ev_io* watcher, int revents);
 void uv__server_io(EV_P_ ev_io* watcher, int revents);
 int uv__accept(int sockfd, struct sockaddr* saddr, socklen_t len);

diff --git a/src/unix/stream.c b/src/unix/stream.c
@@ -75,35 +75,6 @@ int uv__stream_open(uv_stream_t* stream, int fd, int flags) {
 }
 
 
-/* Clears out the write queue, invokes the callbacks attached
- * to each write request. Used when a stream is destroyed.
- */
-static void uv__clear_queue(ngx_queue_t* wq, int status, uv_err_code code) {
-  uv_write_t* req;
-  ngx_queue_t* q;
-
-  while (!ngx_queue_empty(wq)) {
-    q = ngx_queue_head(wq);
-    ngx_queue_remove(q);
-
-    req = ngx_queue_data(q, uv_write_t, queue);
-    if (req->cb) {
-      uv_err_new(req->handle->loop, code);
-      req->cb(req, status);
-    }
-
-    if (req->bufs != req->bufsml)
-      free(req->bufs);
-  }
-}
-
-
-void uv__stream_destroy(uv_stream_t* stream) {
-  uv__clear_queue(&stream->write_queue, -1, UV_EINTR);
-  uv__clear_queue(&stream->write_completed_queue, 0, UV_OK);
-}
-
-
 void uv__server_io(EV_P_ ev_io* watcher, int revents) {
   int fd;
   struct sockaddr_storage addr;

diff --git a/test/test-list.h b/test/test-list.h
@@ -31,7 +31,6 @@ TEST_DECLARE   (tcp_bind_error_fault)
 TEST_DECLARE   (tcp_bind_error_inval)
 TEST_DECLARE   (tcp_bind_localhost_ok)
 TEST_DECLARE   (tcp_listen_without_bind)
-TEST_DECLARE   (tcp_close)
 TEST_DECLARE   (tcp_bind6_error_addrinuse)
 TEST_DECLARE   (tcp_bind6_error_addrnotavail)
 TEST_DECLARE   (tcp_bind6_error_fault)
@@ -118,7 +117,6 @@ TASK_LIST_START
   TEST_ENTRY  (tcp_bind_error_inval)
   TEST_ENTRY  (tcp_bind_localhost_ok)
   TEST_ENTRY  (tcp_listen_without_bind)
-  TEST_ENTRY  (tcp_close)
 
   TEST_ENTRY  (tcp_bind6_error_addrinuse)
   TEST_ENTRY  (tcp_bind6_error_addrnotavail)

diff --git a/test/test-tcp-close.c b/test/test-tcp-close.c