Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the Maven Profile 'mac-profile' and added the missing tools.jar dependency to the sample module #886

Merged
merged 2 commits into from Dec 27, 2013

Conversation

bvahdat
Copy link
Contributor

@bvahdat bvahdat commented Dec 27, 2013

For the details about the 2 commits see the detailed comments inside each of them.

Babak Vahdat added 2 commits December 27, 2013 20:32
Since JDK 6+ on OS X there’s no classes.jar anymore! It’s content is
now part of rt.jar. As an example on my Sony-VAIO laptop running
Mavericks 10.9.1 on it, I’ve got it here:

/Library/Java/JavaVirtualMachines/jdk1.7.0_45.jdk/Contents/Home/jre/lib/
rt.jar

Note that the default-profile is fine for OS-X as well. E.g. I’ve got
JAVA_HOME as:

~>mvn -v
Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da;
2013-02-19 14:51:28+0100)
Maven home: /Users/bvahdat/dev/apache-maven-3.0.5
Java version: 1.7.0_45, vendor: Oracle Corporation
Java home:
/Library/Java/JavaVirtualMachines/jdk1.7.0_45.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.9.1", arch: "x86_64", family: "mac"

And tools.jar is under the path:

/Library/Java/JavaVirtualMachines/jdk1.7.0_45.jdk/Contents/Home/jre/../l
ib/tools.jar

So it’s all fine with the default-profile even on OS-X :)
Otherwise as expected, you get the following warning while jetty boots
up:

WARN  | Scanner-0 | Local JVM discovery disabled as this JVM cannot
access com.sun.tools.attach.VirtualMachine due to:
java.lang.NoClassDefFoundError: com/sun/tools/attach/VirtualMachine
gashcrumb added a commit that referenced this pull request Dec 27, 2013
Removed the Maven Profile 'mac-profile' and added the missing tools.jar dependency to the sample module (thanks @bvahdat!)
@gashcrumb gashcrumb merged commit 56f04a6 into hawtio:master Dec 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants