Skip to content

Commit

Permalink
Fix for serious breach of coding standard reported by John Howe:
Browse files Browse the repository at this point in the history
(02:35:13) johntramp: fredcooke: are you here? it's urgent!
(02:35:52) johntramp: line 321 of commsCore.c,  "it's" instead of "its"
(02:36:12) malcom2073: rofl
(02:36:38) johntramp: this isn't a laughing matter
(02:37:13) johntramp: this is a serious breach of freeems coding standards
(02:50:47) malcom2073: I find it amusing
(02:58:20) johntramp: It is 3am in spain. We need to send Fred a skype wakeup call to ensure we get this fixed asap
(02:58:43) malcom2073: I'd totally do it, if I weren't the proverbial pot here
(03:06:45) johntramp: no answer
(03:06:45) johntramp: this is bad
(03:07:15) johntramp: we must instigate an immediate recall on all freeems firmware
(03:07:19) malcom2073: Can skype leave voicemails?
(03:09:04) johntramp: we can send masterkorp on his bike over to spain
(03:10:26) malcom2073: Cool

Apologies for the 5 hour response time.
  • Loading branch information
fredcooke committed Jan 25, 2013
1 parent 4952a28 commit bda2f06
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/main/commsCore.c
Expand Up @@ -318,7 +318,7 @@ void decodePacketAndRespond(){
unsigned short errorID = 0;
/* This is where all the communication logic resides.
*
* Please Note: Length and it's flag should be set by each return packet
* Please Note: Length and its flag should be set by each return packet
* type handler if required or desired. If an ack has been requested,
* ensure the negative ack flag is set if the operation failed.
*/
Expand Down

0 comments on commit bda2f06

Please sign in to comment.