Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 1ba39226b223
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: fe103357aeed
Choose a head ref
  • 4 commits
  • 4 files changed
  • 1 contributor

Commits on Feb 10, 2013

  1. Revert "typed arrays: copy non-ArrayBuffer in DataView ctor" 

    We're going to follow browser behavior here.

This reverts commit 7b0770b.
    @bnoordhuis
    bnoordhuis committed Feb 10, 2013
    Copy the full SHA
    fd9d8b5 View commit details
    Browse the repository at this point in the history

  2. Revert "typed arrays: only share ArrayBuffer backing store" 

    We're going to fix this differently. The real bug is that
Buffer::HasInstance() returns true for typed arrays.

This reverts commit 01ee551.
    @bnoordhuis
    bnoordhuis committed Feb 10, 2013
    Copy the full SHA
    144e21e View commit details
    Browse the repository at this point in the history

  3. buffer: fix Buffer::HasInstance() check 

    It was returning true for typed arrays. Check that the object was
instantiated with the Buffer constructor.
    @bnoordhuis
    bnoordhuis committed Feb 10, 2013
    Copy the full SHA
    234551a View commit details
    Browse the repository at this point in the history

  4. typed arrays: make DataView throw on non-ArrayBuffer 

    Make the DataView constructor throw an exception when the first
argument is not an ArrayBuffer. Follows the spec and the browsers.
    @bnoordhuis
    bnoordhuis committed Feb 10, 2013
    Copy the full SHA
    fe10335 View commit details
    Browse the repository at this point in the history