Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring for Manage features #305

Merged
merged 5 commits into from Apr 6, 2013
Merged

Refactoring for Manage features #305

merged 5 commits into from Apr 6, 2013

Conversation

eurich
Copy link
Member

@eurich eurich commented Apr 6, 2013

I've left the function pausePermsSave() in the controller for now,

Wasn't sure if we should merge with the other pause functions:
pausePermsSave(), pausAttachmentMaintenance(), pauseRepairProcess()

In the end they all do the same.. stopping a process to avoid overload and continue after a short time..

Hopefully this PR doesn't interfere with @Spuds work on the custom profile fields.
http://www.elkarte.net/index.php?topic=291.msg1936#new

Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
norv added a commit that referenced this pull request Apr 6, 2013
Refactoring for Manage features
@norv norv merged commit eb9bd7f into elkarte:master Apr 6, 2013
@norv
Copy link
Contributor

norv commented Apr 6, 2013

Thank you! Yes, it makes sense to see if we can take all these pause() functions and define the operations to do, with a pause/continue mechanism. It may help us clean up and/or 'standardize' a bit the implementation in other scripts too? (i.e. upgrade, importer)
By the way, don't scheduled tasks do something similar?

@Spuds
Copy link
Contributor

Spuds commented Apr 6, 2013

Hopefully this PR doesn't interfere with Spuds work on the custom profile fields.

LOL .. I was actually going to ask you to do this one next so I did not mess it up for you 😃 Glad its done, now I can get back to scratching my head on those profile fields

@eurich
Copy link
Member Author

eurich commented Apr 6, 2013

Hahaha, seems to be almost perfect timing. 😺 Good luck with the profile fields The code I've seen so far in those files looked complicated, but I haven't checked all details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants