Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicit type conversion error + String#start_with? and #end_with? error #2348

Merged
merged 2 commits into from Jan 12, 2015
Merged

Implicit type conversion error + String#start_with? and #end_with? error #2348

merged 2 commits into from Jan 12, 2015

Conversation

lumeet
Copy link
Contributor

@lumeet lumeet commented Dec 26, 2014

As of 2.0, MRI raises "no implicit conversion..." TypeError in certain situations. I've tried to make respective changes to TypeConverter. While not being sure it's 100% right, at least the following also seems to behave correctly with the patch.

$ rbenv shell 2.0.0-p598
$ ruby -e '"a" + 1'
no implicit conversion of Fixnum into String (TypeError)

$ rbenv shell jruby-9.0.0.0-dev
$ ruby -e '"a" + 1'
TypeError: can't convert Fixnum into String

The String part addresses then test_start_with?and test_end_with? in test_string.rb

@headius headius merged commit c400f2d into jruby:master Jan 12, 2015
@headius
Copy link
Member

headius commented Jan 12, 2015

Thank you!

@lumeet lumeet deleted the string_end_with_implicit_conversion branch January 27, 2015 18:34
@headius headius added this to the JRuby 9.0.0.0-pre1 milestone May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.0.0.0-pre1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lumeet @headius