Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: fa84d1b13154
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 7018c99a31d2
Choose a head ref
  • 10 commits
  • 15 files changed
  • 8 contributors

Commits on May 12, 2014

  1. src: fix StringBytes::Write if string is external

    Signed-off-by: Fedor Indutny <fedor@indutny.com>
    refack authored and indutny committed May 12, 2014
    Copy the full SHA
    9b7888e View commit details
    Browse the repository at this point in the history
  2. node: remove duplicate tickInfo assignment

    When process._setupNextTick() was introduced as the means to properly
    initialize the mechanism behind process.nextTick() a chunk of code was
    left behind that assigned memory to process._tickInfo. This code is no
    longer needed.
    trevnorris committed May 12, 2014
    Copy the full SHA
    53b2e02 View commit details
    Browse the repository at this point in the history
  3. src: fix spelling mistake

    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    Taojie authored and trevnorris committed May 12, 2014
    Copy the full SHA
    0f503cf View commit details
    Browse the repository at this point in the history
  4. readline: fix close event of readline.Interface()

    Not removing 'end' listeners for input and output on the 'close' event
    resulted in an EventEmitter related memory leak.
    
    This issue also might be reproduced at:
    npm/npm#5203
    
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    yorkie authored and trevnorris committed May 12, 2014
    Copy the full SHA
    e1aa066 View commit details
    Browse the repository at this point in the history
  5. buffer: remove Buffer#toArrayBuffer()

    A recent change to v8's API now makes it impossible to memcpy to a
    v8::ArrayBuffer without causing it to be externalized. This means that
    the garbage collector will not automatically free the memory when the
    object is collected.
    
    When/If the necessary API is included to allow the above
    Buffer#toArrayBuffer() will be reintroduced.
    
    Signed-off-by: Timothy J Fontaine <tjfontaine@gmail.com>
    trevnorris committed May 12, 2014
    Copy the full SHA
    b1a44df View commit details
    Browse the repository at this point in the history

Commits on May 13, 2014

  1. test: fixes test/disabled/test-readline.js

    This test is still in test/disabled because it requires a tty, however
    when executed directly this test now passes.
    
    Signed-off-by: Fedor Indutny <fedor@indutny.com>
    dbkaplun authored and indutny committed May 13, 2014
    Copy the full SHA
    52527e0 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    6569812 View commit details
    Browse the repository at this point in the history
  3. readline: implements keypress buffering

    There was an underlying assumption in readline.emitKeypressEvents (and
    by extension emitKey) that the given stream (usually process.stdin)
    would emit 'data' once per keypress, which is not always the case.
    
    This commit buffers the input stream and ensures a 'keypress' event is
    triggered for every keypress (including escape codes).
    
    Signed-off-by: Fedor Indutny <fedor@indutny.com>
    dbkaplun authored and indutny committed May 13, 2014
    Copy the full SHA
    4a90f51 View commit details
    Browse the repository at this point in the history
  4. fs: add consistent flag fall throughs

    stringToFlags() has fall throughs in a case statement.
    However, they are not consistently implemented. This commit adds
    consistency.
    
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    cjihrig authored and trevnorris committed May 13, 2014
    Copy the full SHA
    8ee9f04 View commit details
    Browse the repository at this point in the history
  5. test: rewrite spawnsync test

    The spawnsync test was written wrong, the timeout can never fire before
    the sync process has returned, the delta is immaterial and times when
    it was succeeding are not reliable cases.
    
    Instead verify that the timeout doesn't fire while the sync process is
    happening.
    tjfontaine committed May 13, 2014
    Copy the full SHA
    7018c99 View commit details
    Browse the repository at this point in the history