Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Commit

Permalink
gyp: switch json for pprint when generating config
Browse files Browse the repository at this point in the history
  • Loading branch information
@jbergstroem @bnoordhuis
jbergstroem authored and bnoordhuis committed Dec 19, 2011
1 parent f999411 commit 45605c9
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions configure
View file
Expand Up @@ -2,13 +2,12 @@

import optparse
import os
import json
import pprint
import subprocess
import sys

root_dir = os.path.dirname(__file__)
sys.path.insert(0, os.path.join(root_dir, 'deps', 'v8', 'tools'))
import utils # GuessArchitecture

# parse our options
parser = optparse.OptionParser()
Expand Down Expand Up @@ -262,7 +261,7 @@ print "creating ", fn

f = open(fn, 'w+')
f.write("# Do not edit. Generated by the configure script.\n")
json.dump(output, f, indent=2, skipkeys=True)
pprint.pprint(output, stream=f, indent=2)
f.write("\n")
f.close()

Expand Down

3 comments on commit 45605c9

@ry
Copy link

@ry ry commented on 45605c9 Dec 20, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have broken make install cc @jbergstroem

@ry
Copy link

@ry ry commented on 45605c9 Dec 20, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"fixed" in b603578

@jbergstroem
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSON parsers I tested with seems to be more forgiving. pprint doesn't seem to have enough options to help us with this, so it's either this or the import json debacle :-(

Please sign in to comment.