Item13133: keep calls to numRevisions to a minimum

foswiki · Dec 3, 2014 · 9f81bf9 · 9f81bf9
1 parent 28f5d1a
commit 9f81bf9
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/RCSStoreContrib/lib/Foswiki/Store/Rcs/RcsWrapHandler.pm b/RCSStoreContrib/lib/Foswiki/Store/Rcs/RcsWrapHandler.pm
@@ -325,14 +325,15 @@ sub getRevision {
 sub getInfo {
     my ( $this, $version ) = @_;
 
+    my $numRevs = $this->_numRevisions() || 0;
     if (   ( $this->noCheckinPending() )
-        && ( !$version || $version > $this->_numRevisions() ) )
+        && ( !$version || $version > $numRevs ) )
     {
-        $version = $this->_numRevisions();
+        $version = $numRevs;
     }
     else {
-        $version = $this->_numRevisions() + 1
-          unless ( $version && $version <= $this->_numRevisions() );
+        $version = $numRevs + 1
+          unless ( $version && $version <= $numRevs );
     }
     my ( $rcsOut, $exit ) = Foswiki::Sandbox->sysCommand(
         $Foswiki::cfg{RCS}{infoCmd},