Navigation Menu

Skip to content
This repository has been archived by the owner on May 4, 2018. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: joyent/libuv
base: 95577a869925
Choose a base ref
...
head repository: joyent/libuv
compare: 1258d9e3efeb
Choose a head ref
  • 5 commits
  • 4 files changed
  • 2 contributors

Commits on Mar 8, 2013

  1. windows: link with advapi32 and shell32 libraries 

    Older versions of GYP would set up the Visual Studio project to link
with these libraries by default, but this was changed in r1584 (see
https://codereview.chromium.org/12256017).

Closes #728
    @piscisaureus
    piscisaureus committed Mar 8, 2013
    Copy the full SHA
    aebc0f2 View commit details
    Browse the repository at this point in the history

  2. win/tty: fix case where uv_read_start incorrectly reports failure 

    In very rare circumstances a uv_read_start() call on a uv_tty_t handle
in raw mode would return -1 but there was no actual failure. This patch
fixes that.
    @piscisaureus
    piscisaureus committed Mar 8, 2013
    Copy the full SHA
    b771399 View commit details
    Browse the repository at this point in the history

  3. win/tty: don't touch insert mode or quick edit mode 

    This is a back-port of 4abad23, whichi is supposed to fix
nodejs/node-v0.x-archive#4809.

The private `original_console_mode` field in the uv_tty_t struct has
been renamed, but couldn't be removed because changing the ABI isn't
allowed on stable branches.
    @piscisaureus
    piscisaureus committed Mar 8, 2013
    Copy the full SHA
    83626b6 View commit details
    Browse the repository at this point in the history

  4. win/tty: fix typo in color attributes enumeration

    @piscisaureus
    piscisaureus committed Mar 8, 2013
    Copy the full SHA
    36d19dd View commit details
    Browse the repository at this point in the history

  5. win: map ERROR_INVALID_FUNCTION to EISDIR 

    This error is raised when calling read() or write() on a directory.

A bit of googling turns up some cases where this error can be raised
that are not properly mapped to EISDIR, but are also cases that libuv
doesn't really care about, like the Password Manager API,
GetFirmwareEnvironmentVariable, or CreateTapePartition.

If libuv ever needs to handle these cases, then I suppose that the
ERROR_INVALID_FUNCTION->EISDIR mapping could be done directly in the
fs read() and write() functions, but doing so at this point seems
premature, as it makes the error code mapping a bit more messy.

Fixes nodejs/node-v0.x-archive#4951
    @isaacs @piscisaureus
    isaacs authored and piscisaureus committed Mar 8, 2013
    Copy the full SHA
    1258d9e View commit details
    Browse the repository at this point in the history