TRUNK-4292: Insert order types for drug and test orders #743
Conversation
| <column name="creator">1</column> | ||
| <column name="date_created">CURRENT_TIMESTAMP</column> | ||
| <column name="retired">false</column> | ||
| <column name="uuid"></column> |
There was a problem hiding this comment.
How can I generate an UUID?
There was a problem hiding this comment.
In mysql you can generate one by executing select uuid()
There was a problem hiding this comment.
To be explicit, though, you want to generate one of these manually one time, and then hardcode it here.
There was a problem hiding this comment.
That is correct Darius, my previous comment i only meant to say how to pre generate a uuid
There was a problem hiding this comment.
You also need to insert one for test_order
| @@ -7128,4 +7128,29 @@ | |||
| referencedTableName="users" | |||
| referencedColumnNames="user_id"/> | |||
| </changeSet> | |||
|
|
|||
| <changeSet id="201403070131-TRUNK-4286" author="andras-szell"> | |||
| <preConditions> | |||
There was a problem hiding this comment.
1- onFail action is missing
2- These need to be 2 separate changesets each inserting a single row
3- column name in where clause should be java_class_name and not java_class
I have addressed all the above issues at eee9f95
Insert order types for test and drug orders, these should be inserted conditionally, i.e must check that there are no entries in the order_type table with their java_class column set to org.openmrs.DrugOrder or org.openmrs.TestOrder
NOT READY TO MERGE, ONLY FOR CODE REVIEW