simplify canonicalization a little

mojolicious · Sep 8, 2014 · 13c8577 · 13c8577
1 parent 065e4e3
commit 13c8577
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/lib/Mojo/Path.pm b/lib/Mojo/Path.pm
@@ -14,15 +14,11 @@ sub canonicalize {
   my $self = shift;
 
   my @parts;
-  for my $part (@{$self->parts}) {
+  for my $part (grep { $_ ne '.' && $_ ne '' } @{$self->parts}) {
+    if ($part ne '..') { push @parts, $part }
 
     # ".."
-    if ($part eq '..') {
-      (@parts && $parts[-1] ne '..') ? pop @parts : push @parts, '..';
-    }
-
-    # Something else than "."
-    elsif ($part ne '.' && $part ne '') { push @parts, $part }
+    else { @parts && $parts[-1] ne '..' ? pop @parts : push @parts, '..' }
   }
   $self->trailing_slash(undef) unless @parts;