Run git submodule update after initial clone #406
Conversation
|
I think this is a good idea, but I would like to see a test for this change as well. |
|
Good idea. Here you go! |
Some repositories require that submodules be initialized and updated to be properly built. This is now done during the download phase for every repository.
|
@btaylor Can you update your pull so it can be merged automatically? |
|
@irrationalfab Oh, actually I already merged this, but forgot to close the ticket. (It didn’t autoclose because I had to rebase myself.) |
|
This issue seems to be back, when I run ...
Downloading dependencies
-> Installing MyRepo (0.0.1)
$ /usr/local/bin/git config core.bare
true
> Cloning git repo
$ /usr/local/bin/git branch --all | grep cocoapods-spec$
cocoapods-spec
> Cloning to Pods folder
$ /usr/local/bin/git clone "/Users/peteralaoui/Library/Caches/CocoaPods/Git/216023ffa3ea0bba86dace88a4b33abee8cbef58" "/tmp/CocoaPods/Lint/Pods/MyRepo"
Cloning into '/tmp/CocoaPods/Lint/Pods/MyRepo'...
done.
$ /usr/local/bin/git remote add upstream 'https://github.com/dulaccc/MyRepo.git'
$ /usr/local/bin/git fetch -q upstream
$ /usr/local/bin/git checkout --track -b activated-pod-commit upstream/cocoapods-spec
Switched to a new branch 'activated-pod-commit'
Branch activated-pod-commit set up to track remote branch cocoapods-spec from upstream.
Just downloaded and checked out branch: cocoapods-spec from upstream /Users/peteralaoui/Library/Caches/CocoaPods/Git/216023ffa3ea0bba86dace88a4b33abee8cbef58
> Using existing documentation
...There is no sign of EDIT I finally found where |
|
:submodules => true works fine for me with CocoaPods 0.23.0 Should we close this issue? |
Some repositories require that submodules be initialized and updated to
be properly built. This is now done during the download phase for every
repository.
This was required for the latest version of the Calabash podspec, which now includes calabash-js as a submodule.
I'm putting this pull request out there looking for feedback. Not sure if we want to add another parameter to specify whether you want submodule support or not, but I figured this was the simplest thing I could put out there and get comments on.