Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rubinius/rubinius
base: 8a49a9c046b6
Choose a base ref
...
head repository: rubinius/rubinius
compare: 250e136ba4b9
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Jan 1, 2015

  1. More specs for String#ascii_only? + String#replace 

    The combination of String#replace and String#ascii_only? currently returns
invalid results, see #3236 for more details.
    Yorick Peterse committed Jan 1, 2015
    Copy the full SHA
    402d725 View commit details
    Browse the repository at this point in the history

  2. Reset ascii_only cache when calling String#replace 

    Methods such as IO#read rely on String#replace when reading into a String
buffer. Previously this would not clear the ascii_only cache, causing issues
such as those described in the issues below.

Fixes #3236
Fixes #3234
    Yorick Peterse committed Jan 1, 2015
    Copy the full SHA
    250e136 View commit details
    Browse the repository at this point in the history