Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about hook the action? #498

Merged
merged 1 commit into from Jun 6, 2013
Merged

What about hook the action? #498

merged 1 commit into from Jun 6, 2013

Conversation

emanuele45
Copy link
Contributor

That's something I always wanted to do... :P
Dunno if it fits into the general design, up to you. ;)

Signed-off-by: emanuele <emanuele45@gmail.com>
norv added a commit that referenced this pull request Jun 6, 2013
@norv norv merged commit b94dccc into elkarte:master Jun 6, 2013
@norv
Copy link
Contributor

norv commented Jun 6, 2013

Show off your mod. I'm not convinced that too generic is the way to go to add a layer to a specific page. But, it makes sense to extend virtually action_something().

OTOH, to note: this is probably not ok yet: without the controller name (or action=) name, the function_name_* hook will have name conflicts.

@emanuele45
Copy link
Contributor Author

lol
Yes, I don't know if it is good or not, that's why I asked for opinions... 👼

@norv
Copy link
Contributor

norv commented Jun 6, 2013

I merged it to allow us to see it, try to use it, and improve it. :) And, of course, to allow us to blame Ema if we didn't notice something, lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants