Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: de312cfd7c21
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 979d0ca874df
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Sep 29, 2014

  1. http: cleanup setHeader() 

    Several fields on OutgoingMessage were set after instantiation. These
have been included in the constructor to prevent mutation of the object
map after instantiation.

"name" is now explicitly checked to be a string. Where before if a
non-string was passed the following cryptic error was thrown:

    _http_outgoing.js:334
      var key = name.toLowerCase();
                     ^
    TypeError: undefined is not a function

Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    @trevnorris
    trevnorris committed Sep 29, 2014
    Copy the full SHA
    979d0ca View commit details
    Browse the repository at this point in the history