Remove unnecessary prints and String-Casts #162
Merged
+8
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -295,8 +294,8 @@ def adjust_pip(self, xpos, ypos, width, height): | |||
| try: | |||
| conn = self.connection.adjust_pip(xpos, ypos, width, height) | |||
| res = conn.unpack()[0] | |||
| print "adjust pip xpos:%s ypos:%s w:%s h:%s" % ( | |||
| str(xpos), str(ypos), str(width), str(height)) | |||
| print "adjust pip xpos:%u ypos:%u w:%u h:%u" % ( | |||
There was a problem hiding this comment.
I'm guessing these should actually be %i - but these prints should probably be removed anyway - see https://github.com/timvideos/gst-switch/issues/159
The controller should not print to stdout anyway
|
I'm absolutely with you. The controller should not print to stdout anyway. |
|
|
| print "Click video: xpos:%s ypos:%s width:%s height:%s" % ( | ||
| str(xpos), str(ypos), str(width), str(height)) | ||
| else: | ||
| if not res is True: |
There was a problem hiding this comment.
Here you should use;
if res is not True:Coming from other languages you might expect the above to be equivalent to the following, but it instead does what the english says;
if res is (not True):
|
Looks like landscape actually picked up on this "code smell" -> https://landscape.io/diff/81447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.