Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-4254 : Allow configurable number of days after which visit can be auto closed #629

Closed
wants to merge 3 commits into from

Conversation

endeepak
Copy link
Contributor

I have changed AutoCloseVisitsTask to read a global property which indicates minimum number of visit days allowed before auto closing visit. The default value will be 0, so it continues to work the same way it is now.

@dkayiwa
Copy link
Member

dkayiwa commented Feb 11, 2014

Do you mind adding a unit test for this? :)

@dkayiwa
Copy link
Member

dkayiwa commented Feb 11, 2014

Feel free to reopen when you are done with the above. :)

@dkayiwa dkayiwa closed this Feb 11, 2014
@endeepak
Copy link
Contributor Author

Thanks reviewing the commit. I have added the tests and pushed it into same branch https://github.com/endeepak/openmrs-core/commit/8f7ff055a3bb079cfe41aed5d0cfffbef9a602f8. I don't see an option to re-open the pull request here. It may be due to repository permissions.

Please let me know if I need to raise another request.

@dkayiwa dkayiwa reopened this Feb 11, 2014
Changed assertions tests to be more readable.
Plus the formatting changes done by maven plugin.
@endeepak
Copy link
Contributor Author

I have made necessary changes in https://github.com/endeepak/openmrs-core/commit/bc7f06abe9d8b74f3ce5f8f5bb169df9c06d0e2f. Unfortunately it includes the formatting changes which I forgot to commit in last check in.

@dkayiwa
Copy link
Member

dkayiwa commented Feb 17, 2014

@dkayiwa dkayiwa closed this Feb 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants