Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-4222: SonarQube - Dead store to local variable #550

Merged
merged 1 commit into from Jan 22, 2014

Conversation

lrozanski
Copy link
Contributor

No description provided.

@dkayiwa
Copy link
Member

dkayiwa commented Jan 20, 2014

Did you do these changes automatically or did you first manually look at each? All the changes in other classes look fine apart from: ArdenBaseTreeParser.java
Some of the changes there may introduce bugs.
Because of this: "Note that Sun's javac compiler often generates dead stores for final local variables. Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives", i feel like we should not automate this in particular. We need to manually look at each one by one. :)

@dkayiwa
Copy link
Member

dkayiwa commented Jan 20, 2014

@dkayiwa
Copy link
Member

dkayiwa commented Jan 22, 2014

@lrozanski am ok with all other changes save the ones in the file "ArdenBaseTreeParser.java"
This requires a manual inspection for each line you want to change (instead of the automated one) because of its complexity and the possibility of false positives which could introduce bugs.

@lrozanski
Copy link
Contributor Author

All of the lines I deleted were never used anywhere else and only had one occurrence. They were safe to delete.

@dkayiwa
Copy link
Member

dkayiwa commented Jan 22, 2014

Let me put it this way, when it comes to this particular class, which has lots of deletions, did you do them manually one by one? Or automated it?

@lrozanski
Copy link
Contributor Author

I have not deleted a single line automatically, from any file. All of the changes I made were done manually, and I checked each line in question for this particular class before deleting anything.

dkayiwa added a commit that referenced this pull request Jan 22, 2014
TRUNK-4222: SonarQube - Dead store to local variable
@dkayiwa dkayiwa merged commit d5deed1 into openmrs:master Jan 22, 2014
RandilaP pushed a commit to RandilaP/openmrs-core that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants