Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mantisbt/mantisbt
base: cad51f2
Choose a base ref
...
head repository: mantisbt/mantisbt
compare: 955d1cb
Choose a head ref
  • 3 commits
  • 5 files changed
  • 1 contributor

Commits on Sep 5, 2011

  1. Remove use of filter_var(...) for master-1.2.x 

    Robert Munteanu correctly mentioned on the mailing list that the
master-1.2.x branch needs to work with PHP 5.1. The filter_var(...)
function is not available in PHP <5.2 and therefore we can't use it in
the master-1.2.x branch.

We can achieve similar results by removing all null characters from the
string (\0). This is OK for our use case which is the use of
$_SERVER['SCRIPT_NAME'] - a value that is set by the server and cannot
be manipulated by remote users (like PHP_SELF).
    @davidhicks
    davidhicks committed Sep 5, 2011
    Copy the full SHA
    cb67e6a View commit details
    Browse the repository at this point in the history

  2. Bump version to 1.2.8 and update release notes

    @davidhicks
    davidhicks committed Sep 5, 2011
    Copy the full SHA
    9883363 View commit details
    Browse the repository at this point in the history

  3. Fix #13141: Incorrect parameters to config_get function 

    Thanks to Todd Whitesel for finding this problem in filter_api.php and
to Roland Becker for providing further assistance.

I have grepped the source code and reviewed all other calls to
config_get to ensure they correctly use parameters. There was one
additional bug discovered in bug_report_page.php.
    @davidhicks
    davidhicks committed Sep 5, 2011
    Copy the full SHA
    955d1cb View commit details
    Browse the repository at this point in the history