Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 846f304fa80c
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: f3189ace6b5e
Choose a head ref
  • 4 commits
  • 8 files changed
  • 1 contributor

Commits on Feb 26, 2014

  1. test: add failing http agent: null test 

    See #7012.
    @TooTallNate
    TooTallNate committed Feb 26, 2014
    Copy the full SHA
    d307beb View commit details
    Browse the repository at this point in the history

  2. http, https: don't depend on globalAgent 

    For the `request()` and `get()` functions. I could never
really understand why these two functions go through agent
first... Especially since the user could be passing `agent: false`
or a different Agent instance completely, in which `globalAgent`
will be completely bypassed.

Moved the relevant logic from `Agent#request()` into the
`ClientRequest` constructor.

Incidentally, this commit fixes #7012 (which was the original
intent of this commit).
    @TooTallNate
    TooTallNate committed Feb 26, 2014
    Copy the full SHA
    d6bbb19 View commit details
    Browse the repository at this point in the history

  3. test: update "http-*" tests to only use public API 

    Don't invoke the `agent.requst()` or `agent.get()` functions
directly. Instead, use the public API and pass the agent
instance in as the `agent` option.
    @TooTallNate
    TooTallNate committed Feb 26, 2014
    Copy the full SHA
    0a5d8ca View commit details
    Browse the repository at this point in the history

  4. http: remove the circular dependency 

    Between `ClientRequest` and `Agent`. The circular require was doing
weird things at load time, like making the `globalAgent` property
be `undefined` from within the context of the "_http_client"
module.

Removing the circular dependency completely fixes this.

This commit effectively removes the undocumented `Agent#request()`
and `Agent#get()` functions.
    @TooTallNate
    TooTallNate committed Feb 26, 2014
    Copy the full SHA
    f3189ac View commit details
    Browse the repository at this point in the history