TRUNK-3383 HandlerUtil.getPreferredHandler(Class<H> handlerType, Class<T... #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s<T> type) throws an exception if top-ranked handlers have the same order ranking TRUNK-3383 HandlerUtil.getPreferredHandler(Class<H> handlerType, Class<T> type) throws an exception if top-ranked handlers have the same order ranking TRUNK-3383 HandlerUtil.getPreferredHandler(Class<H> handlerType, Class<T> type) throws an exception if top-ranked handlers have the same order ranking
|
|
||
| if (mostSpecificSupportsInFirstHandler.isAssignableFrom(mostSpecificSupportsInSecondHandler)) { | ||
| return secondHandler; | ||
| } else { |
There was a problem hiding this comment.
shouldn't this be:
else if (mostSpecificSupportsInSecondHandler.isAssignableFrom(mostSpecificSupportsInFirstHandler))
Because the supported classes won't always be sub and super class to each other, here you are assuming it is e.g Patient and Person but it could be Patient and Encounter, i think you should still throw the exception as before if none of the classes is a subclass of the other when the order is the same
|
Closing because author abandoned it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...> type) throws an exception if top-ranked handlers have the same order ranking
TRUNK-3383 HandlerUtil.getPreferredHandler(Class handlerType, Class type) throws an exception if top-ranked handlers have the same order ranking