small optimizations

mojolicious · Sep 3, 2012 · 67fab50 · 67fab50
1 parent 57a3cae
commit 67fab50
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/lib/Mojo/Headers.pm b/lib/Mojo/Headers.pm
@@ -98,22 +98,19 @@ sub parse {
   while (defined(my $line = get_line \$self->{buffer})) {
 
     # Check line size limit
-    if (length $line > $max) {
-      $self->{limit} = $self->{state} = 'finished';
-      return $self;
-    }
+    return $self->tap(sub { $_->{limit} = $_->{state} = 'finished' })
+      if length $line > $max;
 
     # New header
-    elsif ($line =~ /^(\S+)\s*:\s*(.*)$/) { push @$headers, $1, $2 }
+    if ($line =~ /^(\S+)\s*:\s*(.*)$/) { push @$headers, $1, $2 }
 
     # Multiline
     elsif (@$headers && $line =~ s/^\s+//) { $headers->[-1] .= " $line" }
 
     # Empty line
     else {
       $self->add(splice @$headers, 0, 2) while @$headers;
-      $self->{state} = 'finished';
-      return $self;
+      return $self->tap(sub { $_->{state} = 'finished' });
     }
   }
 
@@ -128,8 +125,7 @@ sub referrer { scalar shift->header(Referer => @_) }
 
 sub remove {
   my ($self, $name) = @_;
-  delete $self->{headers}{lc $name};
-  return $self;
+  return $self->tap(sub { delete $_->{headers}{lc $name} });
 }
 
 sub to_hash {