Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We want the first PrevSuccessfullBuild, not the last one ! #1455

Merged
merged 1 commit into from Dec 16, 2014

Conversation

benallard
Copy link
Contributor

This is part of TRAC-3071

@delanne

@@ -72,7 +72,7 @@ def getPrevSuccessfulBuild(self, builderid, number, ssBuild):
matchssBuild = set([(ss['repository'],
ss['branch'],
ss['codebase']) for ss in ssBuild])
while True:
while rv is None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the logic here.

In the line below, right after the only assignment to rv we break out of the loop.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that loop, the inner one. That's exactly what we're fixing there.

@delanne
Copy link
Contributor

delanne commented Dec 16, 2014

👍

sa2ajj pushed a commit that referenced this pull request Dec 16, 2014
We want the first PrevSuccessfullBuild, not the last one !
@sa2ajj sa2ajj merged commit 393a154 into buildbot:master Dec 16, 2014
@benallard benallard deleted the patch-1 branch December 16, 2014 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants