Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRUNK-4331] Creating CONTRIBUTING.md file #814

Merged
merged 2 commits into from Mar 27, 2014
Merged

[TRUNK-4331] Creating CONTRIBUTING.md file #814

merged 2 commits into from Mar 27, 2014

Conversation

ghost
Copy link

@ghost ghost commented Mar 23, 2014

Providing an initial version of the CONTRIBUTING.md as described in TRUNK-4331. Needs reviewed for accuracy and completeness.

@bmamlin
Copy link
Member

bmamlin commented Mar 24, 2014

I like the additional detail compared to my draft for contributing in response to our discussion last summer. Could you add a brief Getting Started section at the top that points people to our getting started as a developer wiki page?

3. Create a new Branch:

cd openmrs-core
git checkout -b new_openmrs-core_branch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a good place to promote a convention of naming a branch based on the work being done – e.g.,

git checkout -b TRUNK-4567

Further edits based on feedback from Burke and "Using Git" wiki page.
@ghost ghost assigned bmamlin Mar 24, 2014
@ghost
Copy link
Author

ghost commented Mar 24, 2014

Thanks @bmamlin for initial feedback. Made some improvements ready for further review.

@ghost
Copy link
Author

ghost commented Mar 26, 2014

@dkayiwa & @wluyima - please take a look at c39a27a instead as there have been some changes in the content. Thanks.

dkayiwa added a commit that referenced this pull request Mar 27, 2014
[TRUNK-4331] Creating CONTRIBUTING.md file
@dkayiwa dkayiwa merged commit 7897f5e into openmrs:master Mar 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants