Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: metacpan/metacpan-api
base: fedbc106fbf1
Choose a base ref
...
head repository: metacpan/metacpan-api
compare: 6a7f083cd1b5
Choose a head ref
  • 16 commits
  • 28 files changed
  • 1 contributor

Commits on Oct 23, 2013

  1. Pass string (not object) to Parse::CPAN::Packages::Fast 

    latest version uses different modules and dies upon finding an object.
    @rwstauner
    rwstauner committed Oct 23, 2013
    Copy the full SHA
    fa4bedb View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2013

  1. Put ES info in test diagnostics

    @rwstauner
    rwstauner committed Oct 26, 2013
    Copy the full SHA
    4e4947a View commit details
    Browse the repository at this point in the history

  2. Remove "TODO" from release->first check 

    Module::Faker now supports setting mtimes on generated dists.
    @rwstauner
    rwstauner committed Oct 26, 2013
    Copy the full SHA
    1af9761 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2013

  1. Enable coveralls.io via travis

    @rwstauner
    rwstauner committed Oct 27, 2013
    Copy the full SHA
    c04375b View commit details
    Browse the repository at this point in the history

  2. Check defined-ness to avoid warning

    @rwstauner
    rwstauner committed Oct 27, 2013
    Copy the full SHA
    659575c View commit details
    Browse the repository at this point in the history

  3. Prefer ok(0) to errors in tests

    @rwstauner
    rwstauner committed Oct 27, 2013
    Copy the full SHA
    20a77c0 View commit details
    Browse the repository at this point in the history

  4. Show better diag for autocomplete test failure

    @rwstauner
    rwstauner committed Oct 27, 2013
    Copy the full SHA
    c27fdc0 View commit details
    Browse the repository at this point in the history

  5. Return if code is unexpected to avoid errors

    @rwstauner
    rwstauner committed Oct 27, 2013
    Copy the full SHA
    b575785 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2013

  1. Omit the Module::Faker generated META files for most dists 

    Previous versions of Module::Faker generated no META.json
and a lacking META.yml.  This was good as it enabled us to test our
indexer.  Module::Faker 0.015 now generates fairly complete
META files, so our indexer trusts the META and doesn't do much parsing.
So we omit these files here so that we can upgrade to the newer
Module::Faker and still have our tests pass.
    @rwstauner
    rwstauner committed Oct 28, 2013
    Copy the full SHA
    b392556 View commit details
    Browse the repository at this point in the history

  2. Specify provides to work with/around cpan/module faker 

    see comments inline.
    @rwstauner
    rwstauner committed Oct 28, 2013
    Copy the full SHA
    8b274ec View commit details
    Browse the repository at this point in the history

  3. Require the latest Module::Faker and CPAN::Faker

    @rwstauner
    rwstauner committed Oct 28, 2013
    Copy the full SHA
    a4ea1b3 View commit details
    Browse the repository at this point in the history

  4. Explicitly take specific attributes from meta object 

    The CPAN::Meta object has a 'provides' hash,
but the Release Document has a 'provides' array.
ES 0.20.2 doesn't care, but ES 0.20.6+ spews errors.
I noticed this when Module::Faker upgraded
and started generating META files with 'provides' hashes.
    @rwstauner
    rwstauner committed Oct 28, 2013
    Copy the full SHA
    5263ac3 View commit details
    Browse the repository at this point in the history

  5. Sort autocomplete secondarily on documentation 

    Older ES seemed to sort them alphabetically
however 0.90.5 doesn't seem to.
Sorting explicitly on documentation as a tie breaker
is more reliable for testing and should probably provide
more clear results.
    @rwstauner
    rwstauner committed Oct 28, 2013
    Copy the full SHA
    3815986 View commit details
    Browse the repository at this point in the history

  6. Change pod urls to match new web urls

    @rwstauner
    rwstauner committed Oct 28, 2013
    Copy the full SHA
    716b5e6 View commit details
    Browse the repository at this point in the history

  7. Test how we handle meta 'provides' 

    Ensure that we *are* using it and how.
With the Module::Faker upgrade that added 'provides'
and caused a newer ES to throw errors
I realized that we weren't testing it.
    @rwstauner
    rwstauner committed Oct 28, 2013
    Copy the full SHA
    e14ea54 View commit details
    Browse the repository at this point in the history

  8. Ignore coverage database

    @rwstauner
    rwstauner committed Oct 28, 2013
    Copy the full SHA
    6a7f083 View commit details
    Browse the repository at this point in the history