Changes to Author examples. #7
Conversation
| trace_calls => \*STDOUT, | ||
| transport => 'curl', | ||
| return Search::Elasticsearch->new( | ||
| cxn_pool => "Static::NoPing", |
There was a problem hiding this comment.
We should use single quotes rather than double quotes, unless there's interpolation. ie my $foo = "something $bar "; and my $foo = 'something bar'; Could you swap out the double quotes to single for these cases? It leaves less room for confusion.
|
I think we should merge this pull request once all of the files have been updated. If we don't do this, the repo will be left in an unusable state. |
| scroll => "5m", | ||
| index => "v0", | ||
| type => "author", | ||
| size => 1, |
There was a problem hiding this comment.
The size has been changed from 100 to 1, which is a lot of queries. I'm guessing you had the lower number for debugging?
|
Looks great! I tested all of the changed scripts and I'm happy to say that they all work great after a fresh "carton install". 👍 |
|
@Talina06 As part of your work, could you port these over to the examples repository as well? https://github.com/CPAN-API/cpan-api/wiki/Useful-Example-Searches |
|
@oalders : Sure I'll add it. 👍 |
@oalders : I have made changes to 3 scripts in the author folder.
Could you please review them?
Thanks :)