Hierarchy children #382
Closed
Hierarchy children #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedoraResourceImpl.java, and exposing the hierarchy levels through the IdentifierConverter and IdentifierTranslator on behalf of the getChildren() implementation.
hierarchy rdf triples for REST web UI.
| private static void findChildren(final Node node, final List<Node> children, final boolean recurse) | ||
| throws RepositoryException { | ||
| if (node.getNodes() == null) { | ||
| System.out.println("Null nodes"); |
There was a problem hiding this comment.
Line 450 will hit an NPE if node.getNodes() == null.
We probably want to LOG and return.
|
Okay, corrected to log and return with the new commit. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/s/projects/684825/stories/71611298
awoods: Nice "git cherry-pick"! Thanks.