Apply optimize stream refactoring. #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks but those spots will not benefit from parallelism. The streams have low number of elements (<20), so the overhead of thread switching will probably make the parallel version slower. And the part that most likely is the bottleneck in this application (bytecode loading) cannot be parallelized, or would complicate the program needlessly, and anyways it runs fast enough. |
|
Thank you for the feedback and consideration!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are in the process of evaluating a research project associated with an automated refactoring tool that attempts to optimize Java 8 streams for maximum performance. In the case of your project, it converted several streams to parallel. The tool is very conservative, meaning that it goes through an extensive static analysis to ensure that the transformation is safe, i.e., original program semantics have been preserved. However, this also means that the proposed changes can be a proper subset of all streams that could be optimized (say, by a human expert developer).
We also ran your test suite before and after our changes and verified that the test results matched. In your project's case, both versions past all tests.
We would appreciate any feedback on the change set that you have. If the changes are acceptable to you, we would also appreciate it if you could accept this pull request so that we may assess the impact of our tool. Thank you for your time and consideration!