Skip to content

Commit 3bf3249

Browse files
PenguinDadZeno-
PenguinDad
authored andcommittedNov 21, 2014
Fix leaking globals in flowers and default mapgen.lua
Signed-off-by: Craig Robbins <kde.psych@gmail.com>
1 parent e71b71c commit 3bf3249

File tree

2 files changed

+10
-14
lines changed

2 files changed

+10
-14
lines changed
 

‎mods/default/mapgen.lua

+6-8
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ function default.mgv6_ongen(minp, maxp, seed)
278278
end
279279
end
280280
end
281-
281+
282282
function default.make_cactus(pos, size)
283283
for y=0,size-1 do
284284
local p = {x=pos.x, y=pos.y+y, z=pos.z}
@@ -377,7 +377,7 @@ function default.mgv6_ongen(minp, maxp, seed)
377377
break
378378
end
379379
end
380-
380+
381381
if ground_y then
382382
local p = {x=x,y=ground_y+1,z=z}
383383
local nn = minetest.get_node(p).name
@@ -388,14 +388,14 @@ function default.mgv6_ongen(minp, maxp, seed)
388388
-- If desert sand, add dry shrub
389389
if nn == "default:desert_sand" then
390390
minetest.set_node(p,{name="default:dry_shrub"})
391-
391+
392392
-- If dirt with grass, add grass
393393
elseif nn == "default:dirt_with_grass" then
394394
minetest.set_node(p,{name="default:grass_"..pr:next(1, 5)})
395395
end
396396
end
397397
end
398-
398+
399399
end
400400
end
401401
end
@@ -406,9 +406,8 @@ end
406406
-- Detect mapgen and register suitable on-generated function
407407
--
408408

409-
minetest.register_on_mapgen_init(function(MapgenParams)
410-
mgname = MapgenParams.mgname
411-
if mgname == "v6" then
409+
minetest.register_on_mapgen_init(function(mg_params)
410+
if mg_params.mgname == "v6" then
412411
minetest.register_on_generated(default.mgv6_ongen)
413412
end
414413
end)
@@ -466,4 +465,3 @@ function default.generate_nyancats(minp, maxp, seed)
466465
end
467466

468467
minetest.register_on_generated(default.generate_nyancats)
469-

‎mods/flowers/mapgen.lua

+4-6
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ function flowers.mgv6ongen(minp, maxp, seed)
2626
break
2727
end
2828
end
29-
29+
3030
if ground_y then
3131
local p = {x=x,y=ground_y+1,z=z}
3232
local nn = minetest.get_node(p).name
@@ -54,7 +54,7 @@ function flowers.mgv6ongen(minp, maxp, seed)
5454
end
5555
end
5656
end
57-
57+
5858
end
5959
end
6060
end
@@ -63,10 +63,8 @@ end
6363

6464
-- Enable in mapgen v6 only
6565

66-
minetest.register_on_mapgen_init(function(MapgenParams)
67-
mgname = MapgenParams.mgname
68-
if mgname == "v6" then
66+
minetest.register_on_mapgen_init(function(mg_params)
67+
if mg_params.mgname == "v6" then
6968
minetest.register_on_generated(flowers.mgv6ongen)
7069
end
7170
end)
72-

2 commit comments

Comments
 (2)

HybridDog commented on Nov 21, 2014

@HybridDog
Contributor

What shall I do if something global could be defined before?
https://github.com/HybridDog/nuke/blob/master/init.lua#L9
this causes a warning message

ShadowNinja commented on Nov 26, 2014

@ShadowNinja
Contributor

@HybridDog: The warning is from the global existence check (the = nuke or part).
I have a PR to fix this warning.

Please sign in to comment.