Navigation Menu

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: m-labs/flickernoise
base: 86fef88
Choose a base ref
...
head repository: m-labs/flickernoise
compare: 2d66a34
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Nov 1, 2011

  1. input.c: remove unnecessary casts 

    This patch to Flickernoise removes a number of casts that serve no
purpose and - in the case of handle_midi_msg - clutter code that
needs some more fixing.

I didn't run the code but I checked that the assembler output is
equivalent. It's not identical because the line numbers of four
asserts changed.

There is a bit more redundancy in the form of

  ... | (foo << bar) | ...

which could be written as

  ... | foo << bar | ...

I didn't touch these since some people prefer the parentheses as
part of their coding style. If you want such things gone as well,
please let me know.

- Werner
    @wpwrak
    wpwrak authored and Sebastien Bourdeauducq committed Nov 1, 2011
    Copy the full SHA
    5447460 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:milkymist/flickernoise

    Sebastien Bourdeauducq committed Nov 1, 2011
    Copy the full SHA
    2d66a34 View commit details
    Browse the repository at this point in the history