Cleaning up HeadersJMSIT and added verify to JMSTopicPublisherTest #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajs6f
force-pushed
the
UseJUnit@TestTimeoutAttribute
branch
from
aca8801
to
0ee0e10
Compare
ajs6f
force-pushed
the
UseJUnit@TestTimeoutAttribute
branch
from
0ee0e10
to
9a4f0d1
Compare
| public void testRemoval() throws RepositoryException, InterruptedException, | ||
| JMSException { | ||
| private void awaitMessageOrFail(final String id, final String eventType) { | ||
| await().pollInterval(ONE_SECOND).until(new Callable<Boolean>() { |
There was a problem hiding this comment.
If the pollInterval is 1sec and the timeout (which starts before the polling) is 2secs, it would seem that effectively the wait will just be a single second. Should we adjust either the polling interval or the timeout so the polling gets at least two tries?
Longer timeout.
|
Resolved with: 41e3fb8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/83330628