Fix ascii-only detection of symbol names. #2504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you run the issue described in jruby#1328 with -J-Dfile.encoding=CP1252 then the string length comparison fails. This smoothes over the issue, but it is still possible that there are problems with bytes being read with the JVM's file.encoding rather than the encoding specified in the magic comment. Closes jruby#1328
|
I would apply this since it would clear up the specific problem reported in #1328, but I am worried if I do then we will wallpaper over the real issue which is getting wrong encoding bytes and feeding them to UTF8 encoding method. So leaving PR open for the time being until I can look at #1328. Once we do find the base case we can apply this since you said this was normative way MRI checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run the issue described in #1328 with
-J-Dfile.encoding=CP1252then the string length comparison fails. This smoothes over the issue,
but it is still possible that there are problems with bytes being read
with the JVM's file.encoding rather than the encoding specified in the
magic comment.
Closes #1328