Annotated all the other exception mappers with @Provider to simplify the WildcardExceptionMapper. #497
Conversation
WildcardExceptionMapper.
|
Please add @Provider to the class: |
| return new AccessControlExceptionMapper() | ||
| .toResponse((java.security.AccessControlException) e); | ||
| } | ||
|
|
||
| if (javax.jcr.AccessDeniedException.class.isAssignableFrom(e.getClass())) { | ||
| return new AccessDeniedExceptionMapper() |
There was a problem hiding this comment.
I would expect that once you add @Provider to the class:
AccessDeniedExceptionMapper.java
...that you should be able to remove the "if" clauses for all of the classes here that are handled by exception-mappers, i.e.:
- AccessDeniedExceptionMapper
- AccessControlExceptionMapper
- LockExceptionMapper
- TransactionMissingExceptionMapper
- JsonParseExceptionMapper
- RepositoryExceptionMapper
removed the "if" clauses when possible as suggested.
|
I've added annotation @Provider for the AccessDeniedExceptionMapper and removed the "if" clauses when possible. But some exceptions are wrapped up by other exceptions that can't be handled by the framework and we may not remove all the "if" clause from the WildcardException. For example, the LockExceptions in the exception cause, which will cause some lock testing cases failed when the "if" clause removed. See lsitu@c07c80f above. |
|
Resolved with: b214e5c |
https://www.pivotaltracker.com/s/projects/684825/stories/78554672
Added exception mappers as the first step to simplify the WildcardExceptionMapper.