Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build failure when RUBYGEMS_GEMDEPS is set to - #3294

Merged
merged 1 commit into from Jan 24, 2015
Merged

fix build failure when RUBYGEMS_GEMDEPS is set to - #3294

merged 1 commit into from Jan 24, 2015

Conversation

bneumeier
Copy link

When RUBYGEMS_GEMDEPS is set to - so that "bundle exec" isn't needed when running ruby programs, the rubinius build fails with:

compiling encoding_compat.cpp
linking shared-object melbourne.so
/tmp/rubinius/staging/bin/rbx extconf.rb
An exception occurred loading Rubygems:

no such file to load -- tsort (LoadError)

Backtrace:

                Rubinius::CodeLoader#load_error at kernel/common/code_loader.rb:445
      Rubinius::CodeLoader#resolve_require_path at kernel/common/code_loader.rb:429
            { } in Rubinius::CodeLoader#require at kernel/common/code_loader.rb:103
                           Rubinius.synchronize at kernel/bootstrap/rubinius.rb:127
                   Rubinius::CodeLoader#require at kernel/common/code_loader.rb:102
                   Rubinius::CodeLoader.require at kernel/common/code_loader.rb:241
  Kernel(Object)#gem_original_require (require) at kernel/common/kernel.rb:755

I've reproduced this with MRI 2.1.5 (rubygems 2.2.2) and MRI 2.2.0 (rubygems 2.4.5) as the build ruby, and confirmed the problem exists when building rbx versions 2.4.1, 2.5.0, and current master. I'm using Ubuntu 13.04 but I suspect that's irrelevant.

Unsetting the environment variable in the Rakefile fixes the issue.

brixen added a commit that referenced this pull request Jan 24, 2015
@brixen
Merge pull request #3294 from bneumeier/prevent-gemdeps-breakage
af7eb1b 
fix build failure when RUBYGEMS_GEMDEPS is set to -
@brixen brixen merged commit af7eb1b into rubinius:master Jan 24, 2015
@bneumeier bneumeier deleted the prevent-gemdeps-breakage branch January 24, 2015 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bneumeier @brixen