Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HTML UI to de-emphasize inlined resources and property 'noise'. ... #148

Merged
merged 1 commit into from Nov 14, 2013

Conversation

cbeer
Copy link
Contributor

@cbeer cbeer commented Nov 13, 2013

@cbeer
Copy link
Contributor Author

cbeer commented Nov 14, 2013

@awoods are you waiting on @mikedurbin before merging this? Or should we merge it now, and then do any other tasks necessary to close the ticket under a separate pull request?

@mikedurbin
Copy link
Contributor

I took it for a test drive in firefox and feel that the collapsed namespaces and emboldened property local names fully addresses my concern about clutter with properties. This looks great.

Collapsing the "Inlined Resources" meets my other concern, though it wasn't obvious to me that you can expand those by clicking in the box around the label for other nodes. Is this a convention that is likely clear to users and is just something I haven't noticed since I'm not a smart phone user? Having a plus, triangle or the text "expand/collapse" to expand and collapse is a UX convention I'm more familiar with. That said, I figured it out after clicking the link once, so it's not a big deal.

I don't want the UI preferences of one individual to trump those of another, so unless you all agree that some sort of explicit link or symbol to expand and collapse is worthwhile, I agree that this successfully completes the goals of the ticket.

@mikedurbin mikedurbin closed this Nov 14, 2013
@mikedurbin mikedurbin reopened this Nov 14, 2013
@cbeer
Copy link
Contributor Author

cbeer commented Nov 14, 2013

@mikedurbin I thought having some kind of expand/collapse would be nice, but it didn't seem to be the bootstrap way. It's actually non-trivial to do (we cheat in Blacklight by doing some SASS mixin stuff), and I don't think should hold up merging this ticket.

@mikedurbin
Copy link
Contributor

Agreed. I think it should be merged as is.

awoods pushed a commit that referenced this pull request Nov 14, 2013
Improve HTML UI to de-emphasize inlined resources and property 'noise'. ...
@awoods awoods merged commit e1e7bd0 into master Nov 14, 2013
@awoods awoods deleted the html-ui branch November 14, 2013 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants