Makes login(String user, String pass) work properly. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Now it don't look up credentials in the usermanager framework, unless a user is logged in * It also gets the values (e.g. the default value for the authorization server) from plugin.xml
| @@ -20,6 +20,7 @@ | |||
| import java.util.List; | |||
| import java.util.Map; | |||
|
|
|||
| import javax.naming.CannotProceedException; | |||
There was a problem hiding this comment.
Checked exception, javax.naming? it already throws BioclipseException which catches Exception and re-throws it in the login(String,String,String) method. I think it is best not to introduce a new exception here.
There was a problem hiding this comment.
I'm changing it to a BioclipseException.
CannotProceedException. Also removes an print out to the console.
|
Iv'e added a commit that fixes the problems noted in previous comments, are the any more issues that I need to resolve before this is merged? |
goglepox
added a commit
that referenced
this pull request
Dec 3, 2013
Makes login(String user, String pass) work properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a user is logged in (the problem in bug 3576)
server) from plugin.xml