css framework #439
Closed
css framework #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orry about common helper classes... Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
|
It makes sense to me... index.css has quite, well, an impressive size 😆 and some most likely are simply needed and won't get changed often if at all.. |
|
will get back on this later, I'd prefer to focus on color variations and default theme html5 improvements |
I think thats a good choice 😃 I removed most of the depreciated tags and overloading of things but did not do any optimizing or consolidation or etc etc ... you know the take advantage of the new things! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for discussion, please don't merge yet..
The idea is to move important css classes / tags to its own file. Designers shoudn't worry much about RTL compability or system relevant parts. Currently it's hardcoded in loadTemplate, maybe we should make it a theme parameter $loadCoreCSS = true;
I've started with the important ones (text-aligns, floats...) but I think we could move other things as well:
...
Designers could still use the theme's index.css to overwrite these classes..