Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 8a407f58b96c
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: ec576235f1f4
Choose a head ref
  • 3 commits
  • 5 files changed
  • 1 contributor

Commits on May 9, 2013

  1. stream: Guarantee ordering of 'finish' event

    In synchronous Writable streams (where the _write cb is called on the
    current tick), the 'finish' event (and thus the end() callback) can in
    some cases be called before all the write() callbacks are called.
    
    Use a counter, and have stream.Transform rely on the 'prefinish' event
    instead of the 'finish' event.
    
    This has zero effect on most streams, but it corrects an edge case and
    makes it perform more deterministically, which is a Good Thing.
    isaacs committed May 9, 2013
    Copy the full SHA
    c38ce9b View commit details
    Browse the repository at this point in the history
  2. stream: Handle multi-corking properly

    This adds proper support for the following situation:
    
        w.cork();
        w.write(...);
        w.cork();
        w.write(...);
        w.uncork();
        w.write(...);
        w.uncork();
    
    This is relevant when you have a function (as we do in HTTP) that wants
    to use cork, but in some cases, want to have a cork/uncork *around*
    that function, without losing the benefits of writev.
    isaacs committed May 9, 2013
    Copy the full SHA
    a584542 View commit details
    Browse the repository at this point in the history
  3. 2
    Copy the full SHA
    ec57623 View commit details
    Browse the repository at this point in the history