TRUNK-4047 ConceptDAO now returns the entire concept tree. #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import org.openmrs.ConceptWord; | ||
| import org.openmrs.Drug; | ||
| import org.openmrs.DrugIngredient; | ||
| import org.openmrs.*; |
There was a problem hiding this comment.
In OpenMRS we don't use wildcard imports. Can you switch this back to what it was before?
|
I haven't looked at the content of this pull request yet, but can you please clean up the formatting and imports? (There's a bit of commentary about the code formatter at https://wiki.openmrs.org/display/docs/Coding+Conventions ) |
…white space changes and wildcard imports.
…more white space changes.
|
Darius, removed all the white-space changes. Sorry about the delay! |
|
Per conversation on the ticket TRUNK-4047, instead of changing this in core code, we'll instead change this to greedily fetch set members in the web services module. That way the java API can continue to let these be lazy. |
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.