Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline::Module::MakeMaker should be merged into Inline::Module. #7

Closed
ingydotnet opened this issue Nov 18, 2014 · 4 comments
Closed

Comments

@ingydotnet
Copy link
Owner

No description provided.

@Leont
Copy link
Collaborator

Leont commented Nov 18, 2014

Why should it? That doesn't make particular sense to me TBH.

@karenetheridge
Copy link
Collaborator

Let's turn this around: what is the difference between Inline::Module and Inline::Module::MakeMaker:

@ingydotnet
Copy link
Owner Author

Inline::Module is the module responsible for doing everything to ship Inline modules.

For a while we had Inline::Module::MakeMaker as a wrapper around EUMM, adding an extra section to WriteMakefile. But that doesn't scale well. So now it just exports a FixMakefile function.

There's no compelling reason to keep calling the module I:M:MM. We can just keep it all in Inline::Module.

Make sense?

@ingydotnet
Copy link
Owner Author

THis has been done for a while now. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants