Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
5 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89f45d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prakashk why the change in signature?
89f45d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that having to handle three cases when using MoeOptionalParameter a little awkward (handling the the Undef case should not be necessary). When I saw your change for the reduce method (where the signature was changed to use MoeSlurpyParameters and needed only two cases), I thought may be I could use the same approach (optional == 0 or 1 parameter, anyway). I should have spent a bit of time in writing a better comment :)
89f45d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prakashk actually the change on reduce was done as part of the branch where I am introducing a type system of sorts (I am still thinking this one through, and will eventually write something up about it). But I did that because I needed to be able to accept any "type" of variable (array, hash, code, scalar) and the type system currently doesn't allow that.