do not end error messages with a dot

mojolicious · Jun 16, 2014 · a9ab209 · a9ab209
1 parent 27d7831
commit a9ab209
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 8 deletions.
diff --git a/lib/Mojo/IOLoop.pm b/lib/Mojo/IOLoop.pm
@@ -100,12 +100,10 @@ sub remove {
 
 sub reset {
   my $self = _instance(shift);
-
   $self->_remove($_)
     for keys %{$self->{acceptors}}, keys %{$self->{connections}};
   $self->reactor->reset;
-  $self->_stop;
-  $self->stop;
+  $self->$_ for qw(_stop stop);
 }
 
 sub server {

diff --git a/lib/Mojo/Server/Morbo.pm b/lib/Mojo/Server/Morbo.pm
@@ -74,7 +74,7 @@ sub _manage {
   sleep 1;
 }
 
-sub _reap { delete $_[0]->{running} while (waitpid -1, WNOHANG) > 0 }
+sub _reap { delete $_[0]{running} while (waitpid -1, WNOHANG) > 0 }
 
 sub _spawn {
   my $self = shift;

diff --git a/lib/Mojo/Template.pm b/lib/Mojo/Template.pm
@@ -240,7 +240,7 @@ sub render_file {
   $self->name($path) unless defined $self->{name};
   my $template = slurp $path;
   my $encoding = $self->encoding;
-  croak qq{Template "$path" has invalid encoding.}
+  croak qq{Template "$path" has invalid encoding}
     if $encoding && !defined($template = decode $encoding, $template);
 
   return $self->render($template, @_);

diff --git a/lib/Mojolicious/Plugin/JSONConfig.pm b/lib/Mojolicious/Plugin/JSONConfig.pm
@@ -12,7 +12,7 @@ sub parse {
   my $config = $json->decode($self->render($content, $file, $conf, $app));
   my $err    = $json->error;
   die qq{Couldn't parse config "$file": $err} if !$config && $err;
-  die qq{Invalid config "$file".} if !$config || ref $config ne 'HASH';
+  die qq{Invalid config "$file"} if !$config || ref $config ne 'HASH';
 
   return $config;
 }

diff --git a/lib/Test/Mojo.pm b/lib/Test/Mojo.pm
@@ -316,8 +316,7 @@ sub _request_ok {
 
   # Establish WebSocket connection
   if ($tx->req->is_handshake) {
-    $self->{messages} = [];
-    $self->{finished} = undef;
+    @$self{qw(finished messages)} = (undef, []);
     $self->ua->start(
       $tx => sub {
         my ($ua, $tx) = @_;