Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal-browser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: aee374fc51ed
Choose a base ref
...
head repository: opal/opal-browser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b2d2ca690635
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Feb 11, 2014

  1. dom/node: make #replace semantics consistent with #add_child

    @meh
    meh committed Feb 11, 2014
    Copy the full SHA
    0b18b52 View commit details

  2. dom/node: use #<< internally instead of #add_child

    @meh
    meh committed Feb 11, 2014
    Copy the full SHA
    b2d2ca6 View commit details
Showing with 10 additions and 3 deletions.
  1. +10 −3 opal/browser/dom/node.rb
13 changes: 10 additions & 3 deletions opal/browser/dom/node.rb
View file
Original file line number Diff line number Diff line change
@@ -59,7 +59,7 @@ def <<(node)
if native?(node)
`#@native.appendChild(node)`
elsif node.respond_to? :each
node.each { |n| add_child(n) }
node.each { |n| self << n }
elsif String === node
`#@native.appendChild(#@native.ownerDocument.createTextNode(node))`
else
@@ -110,7 +110,7 @@ def add_previous_sibling(node)
#
# @param node [Node] the node to append to
def append_to(node)
node.add_child(self)
node << self
end

# Get an array of ancestors.
@@ -366,7 +366,14 @@ def remove_child(node)
# @param node [Node] the node to replace with
# @return [Node] the passed node
def replace(node)
`#@native.parentNode.replaceChild(#@native, #{Native.convert(node)})`
if native?(node)
`#@native.parentNode.replaceChild(#@native, node)`
elsif String === node
`#@native.parentNode.replaceChild(#@native,
#@native.ownerDocument.createTextNode(node))`
else
`#@native.parentNode.replaceChild(#@native, #{Native.convert(node)})`
end

node
end