Catch any Throwable, as getErrorMessage can handle anyway #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goglepox
added a commit
that referenced
this pull request
Nov 19, 2014
Catch any Throwable, as getErrorMessage can handle anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arvid, previously only Exception's were catched, but the bioclipse.core's StringMatrix is throwing Errors (independent whether that is proper code...), but the method that handles the exception can just as well handle any Throwable, so I changed the catch part.
This should fix an issue my PhD student (Bart) was having where doing
stringMatrix.getColumn("Doesn't exist")
caused the full GroovyConsole to crash.