Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-3909, backport edit_privilege fix to 1.9.x #622

Closed
wants to merge 2 commits into from

Conversation

cioan
Copy link
Member

@cioan cioan commented Feb 7, 2014

While working on upgrading Malawi database from 1.7 to 1.9.x I ran in the problem that is described in these openmrs core tickets: TRUNK-3386 and TRUNK-3909. I just backported into 1.9.x liquibase-update-to-latest.xml the changes included here.
Once I made this small change the database upgrade completed successfully (still testing to make sure all malawi features still work).

@dkayiwa
Copy link
Member

dkayiwa commented Feb 7, 2014

@cioan is it possible to have different pull requests for each ticket?

@cioan
Copy link
Member Author

cioan commented Feb 7, 2014

@dkayiwa Hi Daniel, I have posted the same question to @mseaton and @djazayeri and here is Darius answer:
"FWIW from the OpenMRS side I think that adding a new Fix Version to an existing closed ticket (after backporting) is okay.What's not okay is reopening a closed ticket after it has been released. That requires a new ticket as a Bug."

@dkayiwa
Copy link
Member

dkayiwa commented Feb 7, 2014

@cioan since TRUNK-3909 is not yet released, how about creating a separate pull request for it, reopen the ticket, add a new fix version, and then add a comment about the pull request for this particular ticket?

Then create a separate pull request for TRUNK-3386 which is in a Ready for Work status.

What do you think of that? :)

@dkayiwa
Copy link
Member

dkayiwa commented Feb 8, 2014

@cioan just like you have just done a pull request for a back port of TRUNK-4025, do you mind also doing a new pull request that has only the contents of the two commit for TRUNK-3909? That way i will back port exactly was was committed for that ticket. If you feel that there are more changes which are not covered by the existing commits for those two tickets, then create a third pull request. We shall then look for a corresponding ticket, or create a new one. :)

@dkayiwa dkayiwa closed this Feb 8, 2014
@cioan cioan deleted the TRUNK-3909 branch February 10, 2014 13:37
RandilaP pushed a commit to RandilaP/openmrs-core that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants