improved logging of low level exceptions in Mojolicious

mojolicious · Mar 14, 2012 · e5d214d · e5d214d
1 parent 49654b2
commit e5d214d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/Changes b/Changes
@@ -1,6 +1,7 @@
 This file documents the revision history for Perl extension Mojolicious.
 
 2.62    2012-03-14 00:00:00
+        - Improved logging of low level exceptions in Mojolicious.
         - Improved documentation.
 
 2.61    2012-03-14 00:00:00

diff --git a/lib/Mojo.pm b/lib/Mojo.pm
@@ -3,8 +3,10 @@ use Mojo::Base -base;
 
 use Carp 'croak';
 use Mojo::Home;
+use Mojo::IOLoop;
 use Mojo::Log;
 use Mojo::Transaction::HTTP;
+use Mojo::UserAgent;
 use Scalar::Util 'weaken';
 
 has home => sub { Mojo::Home->new };
@@ -13,7 +15,6 @@ has ua   => sub {
   my $self = shift;
 
   # Fresh user agent
-  require Mojo::UserAgent;
   my $ua = Mojo::UserAgent->new->app($self);
   weaken $self;
   $ua->on(error => sub { $self->log->error(pop) });
@@ -33,6 +34,10 @@ sub new {
   $self->log->path($self->home->rel_file('log/mojo.log'))
     if -w $self->home->rel_file('log');
 
+  # Low level exception handling
+  Mojo::IOLoop->singleton->iowatcher->on(
+    error => sub { $self->log->error(pop) });
+
   return $self;
 }
 

diff --git a/lib/Mojo/Server/Hypnotoad.pm b/lib/Mojo/Server/Hypnotoad.pm
@@ -14,9 +14,6 @@ use POSIX qw/setsid WNOHANG/;
 use Scalar::Util 'weaken';
 use Time::HiRes 'ualarm';
 
-# Preload
-use Mojo::UserAgent;
-
 sub DESTROY {
   my $self = shift;