Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cdk/cdk
base: a5ff5fd62bd6
Choose a base ref
...
head repository: cdk/cdk
compare: c26154d78d12
Choose a head ref
  • 6 commits
  • 10 files changed
  • 1 contributor

Commits on Nov 2, 2012

  1. Removed redundant code - we don't need to check whether the bond is a… 

    …lready in the container as we create a new instance. We also don't need to check the array size as this is done by addBond(IBond)

Change-Id: I9b7ddfa356874aee18995e766513cdfca9e6acd2
Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Nov 2, 2012
    Copy the full SHA
    e35e4ef View commit details
    Browse the repository at this point in the history

  2. Removed print to standard out from ChemObjectBuilders 

    Change-Id: I6e69e8bab5781f67346fc9a33240c357d55ef01e
Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Nov 2, 2012
    Copy the full SHA
    a2b5b1e View commit details
    Browse the repository at this point in the history

  3. Added check to ensure a DoubleBondStereochemistry is never created wi… 

    …th more then 2 bonds - this would cause errors with some methods.

Change-Id: Icbfb1902560d1588dec7b95aac3a775053728450
Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Nov 2, 2012
    Copy the full SHA
    d2c3a5b View commit details
    Browse the repository at this point in the history

  4. Added removal of stereo elements in 'removeAllElements()' - documenta… 

    …tion has been updated

Change-Id: I02bd4d114e918c5aaabd881546c29afae55d6800
Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Nov 2, 2012
    Copy the full SHA
    04f6a1e View commit details
    Browse the repository at this point in the history

  5. Removed redundant code from ChemObj clone - the existing code did exa… 

    …ctly what the copy constructor of HashMap does and thus provides a cleaner implementation

Change-Id: I3815bd122d8e1dd943076da434dcda4f40bee35c
Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>

Conflicts:
	src/main/org/openscience/cdk/ChemObject.java
	src/main/org/openscience/cdk/silent/ChemObject.java
    @johnmay @egonw
    johnmay authored and egonw committed Nov 2, 2012
    Copy the full SHA
    229700d View commit details
    Browse the repository at this point in the history

  6. Added cdk-silent dependency for test-renderextra 

    Change-Id: Ie5c9aba77e946a669e173c0cfb6e5079399b0c83
Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Nov 2, 2012
    Copy the full SHA
    c26154d View commit details
    Browse the repository at this point in the history